From 9fd0d4b8b95bd3d47f80688ba3e7f37c58912436 Mon Sep 17 00:00:00 2001 From: Kristian Rietveld Date: Sun, 30 Apr 2006 15:49:25 +0000 Subject: [PATCH] Fix for #340200, spotted by Torsten Schoenfeld. 2006-04-30 Kristian Rietveld Fix for #340200, spotted by Torsten Schoenfeld. * gtk/gtktreeview.c (gtk_tree_view_get_cell_area): fix up logic calculating the level indentation, (gtk_tree_view_start_editing): remove code calculating the level indentation, since _get_cell_area() takes care of this for us. --- ChangeLog | 9 +++++++++ ChangeLog.pre-2-10 | 9 +++++++++ gtk/gtktreeview.c | 23 +++-------------------- 3 files changed, 21 insertions(+), 20 deletions(-) diff --git a/ChangeLog b/ChangeLog index b8a952aabb..f606fc1c8b 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,12 @@ +2006-04-30 Kristian Rietveld + + Fix for #340200, spotted by Torsten Schoenfeld. + + * gtk/gtktreeview.c (gtk_tree_view_get_cell_area): fix up logic + calculating the level indentation, + (gtk_tree_view_start_editing): remove code calculating the + level indentation, since _get_cell_area() takes care of this for us. + 2006-04-30 Matthias Clasen Fix problems with setting symbolic colors from rc files. diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10 index b8a952aabb..f606fc1c8b 100644 --- a/ChangeLog.pre-2-10 +++ b/ChangeLog.pre-2-10 @@ -1,3 +1,12 @@ +2006-04-30 Kristian Rietveld + + Fix for #340200, spotted by Torsten Schoenfeld. + + * gtk/gtktreeview.c (gtk_tree_view_get_cell_area): fix up logic + calculating the level indentation, + (gtk_tree_view_start_editing): remove code calculating the + level indentation, since _get_cell_area() takes care of this for us. + 2006-04-30 Matthias Clasen Fix problems with setting symbolic colors from rc files. diff --git a/gtk/gtktreeview.c b/gtk/gtktreeview.c index 1fff6384ff..e92e3ad639 100644 --- a/gtk/gtktreeview.c +++ b/gtk/gtktreeview.c @@ -11847,13 +11847,10 @@ gtk_tree_view_get_cell_area (GtkTreeView *tree_view, if (column && gtk_tree_view_is_expander_column (tree_view, column)) { - gint depth = gtk_tree_path_get_depth (path) - 1; + gint depth = gtk_tree_path_get_depth (path); - if (depth > 0) - { - rect->x += (depth - 1) * tree_view->priv->level_indentation; - rect->width -= (depth - 1) * tree_view->priv->level_indentation; - } + rect->x += (depth - 1) * tree_view->priv->level_indentation; + rect->width -= (depth - 1) * tree_view->priv->level_indentation; if (TREE_VIEW_DRAW_EXPANDERS (tree_view)) { @@ -13474,20 +13471,6 @@ gtk_tree_view_start_editing (GtkTreeView *tree_view, tree_view->priv->focus_column, &cell_area); - if (gtk_tree_view_is_expander_column (tree_view, tree_view->priv->focus_column)) - { - gint depth = gtk_tree_path_get_depth (cursor_path); - - cell_area.x += (depth - 1) * tree_view->priv->level_indentation; - cell_area.width -= (depth - 1) * tree_view->priv->level_indentation; - - if (TREE_VIEW_DRAW_EXPANDERS (tree_view)) - { - cell_area.x += depth * tree_view->priv->expander_size; - cell_area.width -= depth * tree_view->priv->expander_size; - } - } - if (_gtk_tree_view_column_cell_event (tree_view->priv->focus_column, &editable_widget, NULL, -- 2.30.2